Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18029 )
Change subject: [tools] KUDU-3337 Add unsafe_create_cmeta tool ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/18029/7/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/18029/7/src/kudu/tools/tool_action_local_replica.cc@705 PS7, Line 705: ContainsKey I'm not sure ContainsKey() works as expected with non-dictionary containers such as std::vector, but I might be missing something here. http://gerrit.cloudera.org:8080/#/c/18029/7/src/kudu/tools/tool_action_local_replica.cc@1431 PS7, Line 1431: voter Shouldn't this be somehow encoded in the Raft config-related parameters, in per-member fashion? If it seems a bit cumbersome to allow specifying whether a particular Raft peer is a VOTER/NON_VOTER in this patch, I'm totally fine with addressing that in a separate follow-up changelist. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/18029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I136cc5b5797420a9ca9156f37c3e281da0c265d7 Gerrit-Change-Number: 18029 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 06 Nov 2023 22:08:37 +0000 Gerrit-HasComments: Yes
