Hello Marton Greber, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20716
to look at the new patch set (#6).
Change subject: Issue a warning on parameter heap_sample_every_n_bytes.
......................................................................
Issue a warning on parameter heap_sample_every_n_bytes.
Parameter heap_sample_every_n_bytes is actually a parameter of
tcmalloc. Setting it to a value greater than 0 will make thread
cache request to page heap for some sample allocations, which
will occupy the lock of page heap. So does the free operation
of the sample.
A tserver with high throughput(especially for upserts) might lose
so much performance because of the lock contention of tcmalloc.
Almost all the apply threads are waiting for the spin lock, even if
setting the parameter to a higher value like 1MB.
So give a warning on the parameter heap_sample_every_n_bytes in case
that some users do not know the terrible influence of it.
Change-Id: I00d55126f0cad0ac6cc130576cc45808f96f0a47
---
M src/kudu/util/flags.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/20716/6
--
To view, visit http://gerrit.cloudera.org:8080/20716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I00d55126f0cad0ac6cc130576cc45808f96f0a47
Gerrit-Change-Number: 20716
Gerrit-PatchSet: 6
Gerrit-Owner: Song Jiacheng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Song Jiacheng <[email protected]>
