Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20716 )
Change subject: Issue a warning on parameter heap_sample_every_n_bytes. ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/20716/6/src/kudu/util/flags.cc File src/kudu/util/flags.cc: http://gerrit.cloudera.org:8080/#/c/20716/6/src/kudu/util/flags.cc@99 PS6, Line 99: A value such as 524288 (512KB) is a reasonable choice with relatively " : "low overhead. Consider removing this part as well: it might be a reasonable choice for a tiny test/development minicluster, but sampling every 512KB doesn't make any sense in a production system. -- To view, visit http://gerrit.cloudera.org:8080/20716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00d55126f0cad0ac6cc130576cc45808f96f0a47 Gerrit-Change-Number: 20716 Gerrit-PatchSet: 6 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Song Jiacheng <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2023 17:35:24 +0000 Gerrit-HasComments: Yes
