Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20714 )
Change subject: [ExternalMiniCluster] improve leader_master() ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/20714/8/src/kudu/integration-tests/master_cert_authority-itest.cc File src/kudu/integration-tests/master_cert_authority-itest.cc: http://gerrit.cloudera.org:8080/#/c/20714/8/src/kudu/integration-tests/master_cert_authority-itest.cc@366 PS8, Line 366: cluster_opts_.num_tablet_servers = 0; Please add a comment to explain why to override the default for the 'num_tablet_servers' field. http://gerrit.cloudera.org:8080/#/c/20714/8/src/kudu/integration-tests/security-itest.cc File src/kudu/integration-tests/security-itest.cc: http://gerrit.cloudera.org:8080/#/c/20714/8/src/kudu/integration-tests/security-itest.cc@1446 PS8, Line 1446: cluster_opts_.num_tablet_servers = 0; Please add a comment to explain why to override the default for the 'num_tablet_servers' field. http://gerrit.cloudera.org:8080/#/c/20714/5/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/20714/5/src/kudu/mini-cluster/external_mini_cluster.cc@1043 PS5, Line 1043: found > Then "found" variable will be true and it will exit from the outer loop as Ah, indeed -- I missed that '!found' addition for the outer 'for' cycle. -- To view, visit http://gerrit.cloudera.org:8080/20714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a40fa8e9513066d08b42eefc57a04ba90bded82 Gerrit-Change-Number: 20714 Gerrit-PatchSet: 8 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Tue, 28 Nov 2023 20:16:00 +0000 Gerrit-HasComments: Yes
