Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20714 )
Change subject: [ExternalMiniCluster] improve leader_master() ...................................................................... [ExternalMiniCluster] improve leader_master() ExternalMiniCluster::leader_master() function was improved to use the RPC. However during the dns_alias_itest cases, the host that was stored in the masters_[]->bound_rpc_hostport was a domain name, and the RPC returns IP address and they are compared as strings. This made leader_master() check in ExternalMiniCluster::AddTabletServer() fail. The solution is that bound_rpc_hostport values are converted to Sockaddr and compared to the leader_master_addr that is retrieved from the ConnectToClusterRpc call. ConnectToFollowerMasterTest::AuthnTokenVerifierHaveKeys was changed so it doesn't start any tservers, since leader_master() check can't find leader during tablet server initialization. In master_cert_authority-itest, num of tablet servers was set to zero as well because tablet servers are not needed for the test and waiting for leader made the test flaky. Change-Id: I4a40fa8e9513066d08b42eefc57a04ba90bded82 Reviewed-on: http://gerrit.cloudera.org:8080/20714 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/integration-tests/master_cert_authority-itest.cc M src/kudu/integration-tests/security-itest.cc M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/mini-cluster/external_mini_cluster.h 4 files changed, 31 insertions(+), 13 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4a40fa8e9513066d08b42eefc57a04ba90bded82 Gerrit-Change-Number: 20714 Gerrit-PatchSet: 10 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Ádám Bakai <[email protected]>
