Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20278 )
Change subject: KUDU-3496 support spnego dedicated keytab ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/20278/9/src/kudu/security/init.cc File src/kudu/security/init.cc: http://gerrit.cloudera.org:8080/#/c/20278/9/src/kudu/security/init.cc@90 PS9, Line 90: spnego nit: SPNEGO http://gerrit.cloudera.org:8080/#/c/20278/9/src/kudu/security/test/mini_kdc.h File src/kudu/security/test/mini_kdc.h: http://gerrit.cloudera.org:8080/#/c/20278/9/src/kudu/security/test/mini_kdc.h@95 PS9, Line 95: Status CreateServiceKeytabWithName(const std::string& spn, const std::string& name, nit: missing doc comment http://gerrit.cloudera.org:8080/#/c/20278/9/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/20278/9/src/kudu/server/webserver-test.cc@270 PS9, Line 270: #ifndef __APPLE__ Can you also add a brief summary of why this is ignored (similar to the one in negotiation-test)? It would make it easier to understand without having to leave the editor/IDE. http://gerrit.cloudera.org:8080/#/c/20278/9/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/20278/9/src/kudu/server/webserver.cc@323 PS9, Line 323: const char* kt_file = FLAGS_spnego_keytab_file.empty() ? nit: update the comment above -- To view, visit http://gerrit.cloudera.org:8080/20278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01646207954854d67308f99e6b71ba32c019ed6a Gerrit-Change-Number: 20278 Gerrit-PatchSet: 9 Gerrit-Owner: Halim Kim <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Halim Kim <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 13 Dec 2023 10:20:52 +0000 Gerrit-HasComments: Yes
