Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20792 )
Change subject: [compaction] Log timestamp of two matching DELETE REDO mutations. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20792/1/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/20792/1/src/kudu/tablet/compaction.cc@a479 PS1, Line 479: > Do we still want to have the CHECK leading to server crash and not have any I was under the impression that it just logs the failure and moves on. I guess it is better to keep the check and add log info to it. Something like this: ++ CHECK_NE(0, ret) << Substitute("Both DELETE REDO mutations are stamped with same timestamp i.e. $0", left_last->timestamp().ToString()); ++ -- To view, visit http://gerrit.cloudera.org:8080/20792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I508254a83046818b81db4577bf07265b46a13c9a Gerrit-Change-Number: 20792 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 14 Dec 2023 19:00:23 +0000 Gerrit-HasComments: Yes
