Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20792 )
Change subject: KUDU-3534 [compaction] Log timestamp of two matching DELETE REDO mutations. ...................................................................... Patch Set 2: Code-Review-1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20792/2/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/20792/2/src/kudu/tablet/compaction.cc@483 PS2, Line 483: left_last->timestamp().ToString(), Printing the timestamp is redundant. I checked StringifyMutationList output and it prints strings like "[@17(DELETE)]" where 17 is the timestamp. And using left_last and right_last only prints the last mutation. Using left.redo_head and right.redo_head prints out all the mutations which may be more informative. -- To view, visit http://gerrit.cloudera.org:8080/20792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I508254a83046818b81db4577bf07265b46a13c9a Gerrit-Change-Number: 20792 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Mon, 18 Dec 2023 15:06:14 +0000 Gerrit-HasComments: Yes
