Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20797 )
Change subject: [rpc] increase listened socket backlog up to 512 ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/20797/2/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/20797/2/src/kudu/rpc/messenger.cc@72 PS2, Line 72: 512 How about using FLAGS_rpc_acceptor_listen_backlog instead of a fixed number? http://gerrit.cloudera.org:8080/#/c/20797/2/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/20797/2/src/kudu/server/server_base.cc@684 PS2, Line 684: /proc/sys/net/core/somaxconn nit: This is incorrect for macOS. -- To view, visit http://gerrit.cloudera.org:8080/20797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6f5791acad6ea0787e23d4c71ab2a7ac4c8c1f2 Gerrit-Change-Number: 20797 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 15 Dec 2023 07:52:23 +0000 Gerrit-HasComments: Yes
