Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20797 )
Change subject: [rpc] increase listened socket backlog up to 512 ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20797/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20797/2//COMMIT_MSG@7 PS2, Line 7: increase listened socket backlog up to 512 > Do you think we may also increase number of acceptor threads from default v I'm not sure it makes sense doing that. It will use an extra thread for every RPC interface without actual need for that for most of Kudu clusters deployed. I think it's enough to increase just the backlog as the first line of defense against bursts of requests to establish a new connection. Scaling the size of the acceptor thread pool should be a call made after analyzing the output of 'netstat -s -t' ('netstat -s -p tcp' on BSD systems) command, etc. http://gerrit.cloudera.org:8080/#/c/20797/2/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/20797/2/src/kudu/rpc/messenger.cc@72 PS2, Line 72: 512 > How about using FLAGS_rpc_acceptor_listen_backlog instead of a fixed number Done http://gerrit.cloudera.org:8080/#/c/20797/2/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/20797/2/src/kudu/server/server_base.cc@684 PS2, Line 684: /proc/sys/net/core/somaxconn > nit: This is incorrect for macOS. Done -- To view, visit http://gerrit.cloudera.org:8080/20797 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6f5791acad6ea0787e23d4c71ab2a7ac4c8c1f2 Gerrit-Change-Number: 20797 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 15 Dec 2023 16:26:55 +0000 Gerrit-HasComments: Yes
