Wang Xixu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20833 )

Change subject: [fs] Simplify the data directory inheritance hierarchy
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20833/3/src/kudu/fs/dir_manager.h
File src/kudu/fs/dir_manager.h:

http://gerrit.cloudera.org:8080/#/c/20833/3/src/kudu/fs/dir_manager.h@156
PS3, Line 156: available_space_cache_secs
How about implementing this function here, just like available_bytes()? As this 
function is so much simple.



--
To view, visit http://gerrit.cloudera.org:8080/20833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3
Gerrit-Change-Number: 20833
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com>
Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org>
Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com>
Gerrit-Comment-Date: Wed, 27 Dec 2023 02:11:45 +0000
Gerrit-HasComments: Yes

Reply via email to