Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20833 )
Change subject: [fs] Simplify the data directory inheritance hierarchy ...................................................................... [fs] Simplify the data directory inheritance hierarchy This patch doesn't introduce functional changes, but only simplify the inheritance hierarchy of class Dir to reduce the complex when extend the Dir class, for example, when adding a sub-class of Dir to contain a RocksDB instance, see http://gerrit.cloudera.org:8080/18569. Because there are not sufficient reasons, so the DataDir sub-class is removed and the implementation functions are moved to the super class Dir. Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Reviewed-on: http://gerrit.cloudera.org:8080/20833 Tested-by: Yingchun Lai <[email protected]> Reviewed-by: Ádám Bakai <[email protected]> Reviewed-by: Yifan Zhang <[email protected]> --- M src/kudu/fs/data_dirs.cc M src/kudu/fs/data_dirs.h M src/kudu/fs/dir_manager.cc M src/kudu/fs/dir_manager.h M src/kudu/fs/fs_manager.h 5 files changed, 19 insertions(+), 38 deletions(-) Approvals: Yingchun Lai: Verified Ádám Bakai: Looks good to me, but someone else must approve Yifan Zhang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2d7059e32c7fd8444256ea031bebd153b318a5a3 Gerrit-Change-Number: 20833 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]>
