Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20868 )
Change subject: KUDU-3543 Fix Content-Type headers ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20868/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20868/2//COMMIT_MSG@9 PS2, Line 9: Commit 1e7d1b3d117ca137bdce3d2ec549416d242bdd02 introduced a newly : supported Content-Type: application/octet-stream. The problem is that : in the webserver's path handler functions we only use a bool called : 'is_styled' to decide on the style mode [1]. What way commit 1e7d1b3d1 is related to the essence of this refactoring? I'm not sure I understand. http://gerrit.cloudera.org:8080/#/c/20868/2//COMMIT_MSG@16 PS2, Line 16: I took : the liberty to add the JSON Content-Type and fix these as well. Could you please separate this into its own patch? It would be much easier to reason about track these changes if the refactoring regarding 'is_styled' and this part were in separate patches. http://gerrit.cloudera.org:8080/#/c/20868/2/src/kudu/util/test_util.h File src/kudu/util/test_util.h: http://gerrit.cloudera.org:8080/#/c/20868/2/src/kudu/util/test_util.h@36 PS2, Line 36: using strings::Substitute 'using' in header files in a well known no-no in C++. -- To view, visit http://gerrit.cloudera.org:8080/20868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I746dcfbaadb2fb95292c2d4047cb7adb9971b42f Gerrit-Change-Number: 20868 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 08 Jan 2024 18:37:33 +0000 Gerrit-HasComments: Yes
