Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20868 )
Change subject: KUDU-3543 Fix Content-Type headers ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/20868/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20868/2//COMMIT_MSG@9 PS2, Line 9: This patch addresses an issue with the webserver's the Content-Headers. : The problem is that in the webserver's path handler functions we only : use a bool called 'is_styled' to decide on the style mode [1]. : This patch basically replaces the 'is_styled > What way commit 1e7d1b3d1 is related to the essence of this refactoring? I I just wanted to elaborate that the implementation worked until we had onlye 'text/plain' and 'text/html' (boolean choice). But with the added 3rd Content-Type header, we need to pipe the StyleMode enum to handle all the cases. (I guess my brain went faster than my hands, anyway removed this part) http://gerrit.cloudera.org:8080/#/c/20868/2//COMMIT_MSG@16 PS2, Line 16: ebserver.cc#L671-L672 : > Could you please separate this into its own patch? It would be much easier Makes sense. Did split up the patch. The new rev only contains the refactor part. http://gerrit.cloudera.org:8080/#/c/20868/2/src/kudu/util/test_util.h File src/kudu/util/test_util.h: http://gerrit.cloudera.org:8080/#/c/20868/2/src/kudu/util/test_util.h@36 PS2, Line 36: #define SKIP_IF_SLOW_NOT_ > 'using' in header files in a well known no-no in C++. Done -- To view, visit http://gerrit.cloudera.org:8080/20868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I746dcfbaadb2fb95292c2d4047cb7adb9971b42f Gerrit-Change-Number: 20868 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 09 Jan 2024 16:56:17 +0000 Gerrit-HasComments: Yes
