Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20913 )

Change subject: [master_runner] Destruct server before new one
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20913/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20913/2//COMMIT_MSG@7
PS2, Line 7: [master_runner]
nit: replace this tag with the ticket ID, and rephrase it to something like 
"Destruct master before creating a new one"


http://gerrit.cloudera.org:8080/#/c/20913/2/src/kudu/master/master_runner.cc
File src/kudu/master/master_runner.cc:

PS2:
Can you add a test that would fail with the old behavior and pass with the new 
one?



--
To view, visit http://gerrit.cloudera.org:8080/20913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1019d092bbf9e58f4fc33753a1218bc79735d3
Gerrit-Change-Number: 20913
Gerrit-PatchSet: 2
Gerrit-Owner: Ádám Bakai <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 17 Jan 2024 15:17:21 +0000
Gerrit-HasComments: Yes

Reply via email to