Ádám Bakai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20913 )
Change subject: KUDU-3491 Destruct master before creating a new one ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/20913/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20913/4//COMMIT_MSG@20 PS4, Line 20: This patch fixes KUDU-3491 issue. > nit: no need for this line now as it's in the subject line Done http://gerrit.cloudera.org:8080/#/c/20913/3/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/20913/3/src/kudu/master/dynamic_multi_master-test.cc@1483 PS3, Line 1483: opts_.extra_master_flags.emplace_back("--enable_minidumps=true"); > Can you add a comment that minidumps are disabled for mini cluster by defau Done -- To view, visit http://gerrit.cloudera.org:8080/20913 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c1019d092bbf9e58f4fc33753a1218bc79735d3 Gerrit-Change-Number: 20913 Gerrit-PatchSet: 4 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Wed, 17 Jan 2024 18:08:44 +0000 Gerrit-HasComments: Yes
