Hello Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20908
to look at the new patch set (#2).
Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric
......................................................................
[rpc] introduce rpc_listened_socket_rx_queue_size metric
This patch introduces a new 'rpc_listened_socket_rx_queue_size'
histogram metric for AcceptorPool. The metric allows for tracking
the size of the listened RPC socket's RX queue. The new metric
shows meaningful numbers only on Linux since it's based on the
DiagnosticSocket, where the latter is implemented only on Linux
as of now.
The new metric is sampled by each acceptor thread when accepting
an RPC connection. It's possible to change the frequency of the
sampling (completely disabling it, if necessary) by tuning the
--rpc_listen_socket_stats_every_log2 flag.
I also added basic tests scenarios to cover the newly introduced
functionality.
Change-Id: I83580659bac39d9171f1ee0d0e88676ed0d50b99
---
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/acceptor_pool.h
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/net/diagnostic_socket.cc
M src/kudu/util/net/diagnostic_socket.h
7 files changed, 335 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/20908/2
--
To view, visit http://gerrit.cloudera.org:8080/20908
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I83580659bac39d9171f1ee0d0e88676ed0d50b99
Gerrit-Change-Number: 20908
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>