Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20908 )
Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20908/2/src/kudu/rpc/acceptor_pool.cc File src/kudu/rpc/acceptor_pool.cc: http://gerrit.cloudera.org:8080/#/c/20908/2/src/kudu/rpc/acceptor_pool.cc@118 PS2, Line 118: $0: invalid setting for $1; must be less than 64" > why should less than 64? Because of the possible width of the counter. Do think anybody needs to do sampling less frequently than once in 2^63 accepted connections? :) -- To view, visit http://gerrit.cloudera.org:8080/20908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83580659bac39d9171f1ee0d0e88676ed0d50b99 Gerrit-Change-Number: 20908 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Tue, 23 Jan 2024 15:15:29 +0000 Gerrit-HasComments: Yes
