Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21018 )
Change subject: KUDU-613: Cleanup of cache code ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/util/cache.h File src/kudu/util/cache.h: http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/util/cache.h@81 PS2, Line 81: // The storage for the key/value pair itself. The data is stored as: : // [key bytes ...] [padding up to 8-byte boundary] [value bytes ...] : uint8_t kv_data[1 > Is it possible to introduce this field only in the patch implementing the S Done http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/util/nvm_cache.h File src/kudu/util/nvm_cache.h: http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/util/nvm_cache.h@34 PS2, Line 34: struct LRUHandle { > Any chance to unify Cache::RLHandle and this handle by templatizing? Align I'll look into it, there's some ASAN errors from trying to templatize the HandleDeleter and PendingHandleDeleter classes that I think are related to the file_cache somehow, still need to debug that first. http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/util/nvm_cache.h@46 PS2, Line 46: Slice key() const { : return Slice(kv_data, key_length); : } > Ditto: is it possible to introduce this field only in the patch implementin Done -- To view, visit http://gerrit.cloudera.org:8080/21018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I506d4577c0ae873b01d7fa4f53846d6fd0f664cf Gerrit-Change-Number: 21018 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 08 Feb 2024 22:03:47 +0000 Gerrit-HasComments: Yes
