Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21018 )
Change subject: KUDU-613: Cleanup of cache code ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/21018/6/src/kudu/util/cache.h File src/kudu/util/cache.h: http://gerrit.cloudera.org:8080/#/c/21018/6/src/kudu/util/cache.h@70 PS6, Line 70: struct RLHandle { > So, the decision is not to try unifying this and util::LRUHandle from nvm_c The key and value data are represented differently between this and LRUHandle from nvm_cache.h. I decided to leave it as is for now. http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/util/nvm_cache.h File src/kudu/util/nvm_cache.h: http://gerrit.cloudera.org:8080/#/c/21018/2/src/kudu/util/nvm_cache.h@34 PS2, Line 34: struct LRUHandle { > It might be something related to the use cases, but overall that's quite su Done http://gerrit.cloudera.org:8080/#/c/21018/6/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/21018/6/src/kudu/util/nvm_cache.cc@200 PS6, Line 200: return *FindP > nit for here and elsewhere in this file: consider introducing corresponding Done http://gerrit.cloudera.org:8080/#/c/21018/6/src/kudu/util/nvm_cache.cc@397 PS6, Line 397: > nit: wrong indent? Done -- To view, visit http://gerrit.cloudera.org:8080/21018 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I506d4577c0ae873b01d7fa4f53846d6fd0f664cf Gerrit-Change-Number: 21018 Gerrit-PatchSet: 7 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 01 Mar 2024 00:23:13 +0000 Gerrit-HasComments: Yes
