Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20899 )
Change subject: [log_block_manager-test] Improve random selection ...................................................................... Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/20899/12/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20899/12/src/kudu/fs/log_block_manager-test.cc@1296 PS12, Line 1296: std::default_random_engine Is it a requirement to use std::default_random_engine which is implementation-defined and can be different on different platforms? A few test scenarios in this file use std::mt19937 engine already, is it possible to use it here as well? http://gerrit.cloudera.org:8080/#/c/20899/12/src/kudu/fs/log_block_manager-test.cc@1297 PS12, Line 1297: rng nit: could use the instance of the 'rng' in-place since it's not needed elsewhere in the code http://gerrit.cloudera.org:8080/#/c/20899/12/src/kudu/fs/log_block_manager-test.cc@1298 PS12, Line 1298: 1 style nit: 1.0 http://gerrit.cloudera.org:8080/#/c/20899/12/src/kudu/fs/log_block_manager-test.cc@1299 PS12, Line 1299: If you want to call AddDeletedBlock for the (1.0 - kLiveBlockRatio) of all the elements in the resulted array and keep just kLiveBlockRatio part, shouldn't that be instead ids.erase(ids.begin() + kLiveBlockRatio * kNumBlocks, ids.end()) ? -- To view, visit http://gerrit.cloudera.org:8080/20899 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f73f0572319784b07845b02d15a7d3e6f31abce Gerrit-Change-Number: 20899 Gerrit-PatchSet: 12 Gerrit-Owner: Ádám Bakai <aba...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com> Gerrit-Comment-Date: Wed, 14 Feb 2024 20:08:37 +0000 Gerrit-HasComments: Yes
