Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20899 )
Change subject: [log_block_manager-test] Improve random selection ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/20899/12/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20899/12/src/kudu/fs/log_block_manager-test.cc@1299 PS12, Line 1299: // Deletes 'kNumBlocks * (1 - kLiveBlockRatio)' blocks. > No, it wouldn't work. In the test kLiveBlockRatio = 0.1. If I erase everyth Indeed -- if we are about to call AddDeletedBlock() for 90% of all the blocks, then we need to remove 10% of elements of the 'ids' container, so the iterator range for the erase() should be { begin() + 0.9 * size(), end() }, right. The strange thing is that with this patch LogBlockManagerTest.TestContainerBlockLimitingByMetadataSizeWithCompaction with encryption enabled now fails every run, so I suspected something has changed in the logic of this test. Did you look at the root case of those failures? -- To view, visit http://gerrit.cloudera.org:8080/20899 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f73f0572319784b07845b02d15a7d3e6f31abce Gerrit-Change-Number: 20899 Gerrit-PatchSet: 13 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Fri, 23 Feb 2024 18:20:44 +0000 Gerrit-HasComments: Yes
