Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21076 )
Change subject: KUDU-3557 Simple way to change maximum thread cache size of tcmalloc. ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21076/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21076/3//COMMIT_MSG@17 PS3, Line 17: Please check it : for detail. Thank you for adding those graphs in KUDU-3557. For those graphs, could you also please add more information on what is shown on the Y scale of the graphs and how that was measured. Thank you! http://gerrit.cloudera.org:8080/#/c/21076/3/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/21076/3/src/kudu/server/server_base.cc@809 PS3, Line 809: #ifdef TCMALLOC_ENABLED : MallocExtension::instance()->SetNumericProperty( : "tcmalloc.max_total_thread_cache_bytes", FLAGS_tcmalloc_max_total_thread_cache_bytes); : RegisterSpinLockContentionMetrics(metric_entity_); : #endif Does it makes sense to add logging about the inability to apply the settings for --tcmalloc_max_total_thread_cache_bytes when TCMALLOC_ENABLED isn't defined? -- To view, visit http://gerrit.cloudera.org:8080/21076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cb8c6ed6a8f24c63258ae65f8b841fe74b75308 Gerrit-Change-Number: 21076 Gerrit-PatchSet: 3 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 27 Feb 2024 17:22:39 +0000 Gerrit-HasComments: Yes
