Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21076 )
Change subject: KUDU-3557 Simple way to change maximum thread cache size of tcmalloc. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21076/3/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/21076/3/src/kudu/server/server_base.cc@309 PS3, Line 309: 33554432 > nit: replacing it with 32 * 1024 * 1024 would be more descriptive to human Just another thought: given that Kudu servers have many threads by design and usually run 30+ threads in default configuration, maybe set this to 128MByte by default (AFAIK, the default tcmalloc's setting is just 16MByte). -- To view, visit http://gerrit.cloudera.org:8080/21076 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cb8c6ed6a8f24c63258ae65f8b841fe74b75308 Gerrit-Change-Number: 21076 Gerrit-PatchSet: 3 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 27 Feb 2024 19:49:54 +0000 Gerrit-HasComments: Yes
