Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21204 )
Change subject: [debug] Fallback to load from libc ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21204/2/src/kudu/util/debug/unwind_safeness.cc File src/kudu/util/debug/unwind_safeness.cc: http://gerrit.cloudera.org:8080/#/c/21204/2/src/kudu/util/debug/unwind_safeness.cc@80 PS2, Line 80: if (error) { If libc is loaded after kudu_util, then the libc version of dlopen overrides this version. So you bring back the error that this code originally fixed. The state after symbol loading will be the same, as if you would just delete the whole thing from unwind_safenness.cc. -- To view, visit http://gerrit.cloudera.org:8080/21204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83ccb92a32bf431fc5bdae27264969e0e131a475 Gerrit-Change-Number: 21204 Gerrit-PatchSet: 2 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 26 Mar 2024 13:45:44 +0000 Gerrit-HasComments: Yes
