Zoltan Martonka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21204 )

Change subject: [debug] Fallback to load from libc
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21204/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21204/2//COMMIT_MSG@7
PS2, Line 7: [debug] Fallback to load from libc
I think you should use some other tag.
This logic avoid potential for deadlocks in stack trace collection. Production 
systems included.
It can change a kudu server from crashing to deadlock (which is not good).
When I see [debug], I automatically assume it touches something that will never 
happen on production until some1 starts to troubleshoot.



--
To view, visit http://gerrit.cloudera.org:8080/21204
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83ccb92a32bf431fc5bdae27264969e0e131a475
Gerrit-Change-Number: 21204
Gerrit-PatchSet: 2
Gerrit-Owner: Ádám Bakai <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Tue, 26 Mar 2024 13:53:31 +0000
Gerrit-HasComments: Yes

Reply via email to