Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21505 )

Change subject: [util] remove last vestiges of chromium Atomics from metrics
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21505/1/src/kudu/util/metrics.h
File src/kudu/util/metrics.h:

http://gerrit.cloudera.org:8080/#/c/21505/1/src/kudu/util/metrics.h@1203
PS1, Line 1203:   std::atomic<int64_t> value_;
Do you have a plan to replace all the AtomicInt by std::atomic in Kudu?



--
To view, visit http://gerrit.cloudera.org:8080/21505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5feaeffa7912ef93479e2675ea6b27d694c1c5ee
Gerrit-Change-Number: 21505
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Wed, 12 Jun 2024 14:58:45 +0000
Gerrit-HasComments: Yes

Reply via email to