Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21505 )
Change subject: [util] remove last vestiges of chromium Atomics from metrics ...................................................................... Patch Set 1: (1 comment) Thank you for review! http://gerrit.cloudera.org:8080/#/c/21505/1/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/21505/1/src/kudu/util/metrics.h@1203 PS1, Line 1203: std::atomic<int64_t> value_; > Do you have a plan to replace all the AtomicInt by std::atomic in Kudu? Yes, there is an intention to do so. I talked about that with other Kudu committers offline, and so far the it seems everybody I talked was fine with removing chromium atomics gradually. An alternative would be to do it in one patch -- just remove the remaining vestiges of chromium atomics altogether at once, but nobody seems to have time for that. If you have some capacity to do it all at once and post a patch with switching to std::atomic everywhere, please feel free to do so -- such contributions are very welcome! Thanks! -- To view, visit http://gerrit.cloudera.org:8080/21505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5feaeffa7912ef93479e2675ea6b27d694c1c5ee Gerrit-Change-Number: 21505 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 12 Jun 2024 17:29:12 +0000 Gerrit-HasComments: Yes
