Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21560 )
Change subject: KUDU-3371 Add NO_ROCKSDB build option ...................................................................... Patch Set 2: Code-Review+1 Thank you for the change. Could you also add a parameter or an environmental variable for thirdparty build to allow skipping rocks download/build? You can do it in a separate commit if you prefer to. Overall looks good for me. -- To view, visit http://gerrit.cloudera.org:8080/21560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9cfb5e928d6fb995ac667533a3651cad91010c7 Gerrit-Change-Number: 21560 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 04 Jul 2024 08:56:57 +0000 Gerrit-HasComments: No
