Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21560 )
Change subject: KUDU-3371 Add NO_ROCKSDB build option ...................................................................... Patch Set 2: > Patch Set 2: Code-Review+1 > > Thank you for the change. > Could you also add a parameter or an environmental variable for thirdparty > build to allow skipping rocks download/build? You can do it in a separate > commit if you prefer to. > > Overall looks good for me. If we build Kudu thirdparty without rocksdb in the beginning, but if we want to enable NO_ROCKSDB option one day, we have to rebuild the thirdparties (to generate rocksdb libraries) which cost a very long time. But if we build rocksdb libraries regardless of the options, we can switch the option flexibly. The extra cost is some disk space and some time for the initiate thirdparty building, it's acceptable IMO. -- To view, visit http://gerrit.cloudera.org:8080/21560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9cfb5e928d6fb995ac667533a3651cad91010c7 Gerrit-Change-Number: 21560 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Sun, 07 Jul 2024 15:31:11 +0000 Gerrit-HasComments: No
