Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21547 )
Change subject: [java] Various fixes ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/21547/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21547/2//COMMIT_MSG@14 PS2, Line 14: the method returns : either ImmutableList or simple List as a return value, converting the : simple list to ImmutableList would involve a full copy (e.g. : ImmutableList.copyOf()) so there is a potential performance impact nit: it might be useful for future reference to put this explanation and the potential perf hit as a comment to the function. -- To view, visit http://gerrit.cloudera.org:8080/21547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fd8583ad73231da5878414beda143408fab74ad Gerrit-Change-Number: 21547 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 05 Jul 2024 14:35:46 +0000 Gerrit-HasComments: Yes
