Hello Marton Greber, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21547
to look at the new patch set (#4).
Change subject: [java] Various fixes
......................................................................
[java] Various fixes
This commit is a collection of various fixes for Java buildtime
warnings.
There are two WarningSuppressions introduced, both are a bit debatable:
* PartitionPruner.splitIntoHashSpecificRanges() - the method returns
either ImmutableList or simple List as a return value, converting the
simple list to ImmutableList would involve a full copy (e.g.
ImmutableList.copyOf()) so there is a potential performance impact
* TestKuduScanner.testScannerLeaderChanged() - at the end of the method,
a try/catch block's catch branch asserts that the thrownø exception is
not a 'Scanner not found' problem, which is weird only, because during
a green run, the catch branch should not be hit. I'm not sure if this
was done to avoid flakyness.
Change-Id: I9fd8583ad73231da5878414beda143408fab74ad
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/main/java/org/apache/kudu/client/PartitionPruner.java
M
java/kudu-client/src/main/java/org/apache/kudu/client/RangePartitionWithCustomHashSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
8 files changed, 7 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/21547/4
--
To view, visit http://gerrit.cloudera.org:8080/21547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9fd8583ad73231da5878414beda143408fab74ad
Gerrit-Change-Number: 21547
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
