Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21569 )
Change subject: Update CMake to 3.22.6 ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21569/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21569/2//COMMIT_MSG@13 PS2, Line 13: We also have to stay compatible with Ubuntu 18.04. : So, 3.22 is the newest we can go. BTW, what's is the issue with cmake 3.22.6 on Ubuntu 18.04? Does cmake 3.22.6 at least is buildable at Ubuntu 18.04? In general, for thirdparty components, we don't need to stick with particular version that matches 'system package version' for a particular OS, unless there is a strong reason to do so. http://gerrit.cloudera.org:8080/#/c/21569/2//COMMIT_MSG@17 PS2, Line 17: ubuntu 18.04, 20.04, 22.04, rhel 8.10 > It would be great if you can test it on SLES 12 SP5 and SLES 15 SP4/SP5 as +1 I guess it should work, but it make sense to double-check, indeed. http://gerrit.cloudera.org:8080/#/c/21569/2/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/21569/2/thirdparty/vars.sh@61 PS2, Line 61: # Note: CMake gets patched on SLES12SP0. When changing the CMake version, please check if : # cmake-issue-15873-dont-use-select.patch needs to be updated. Is this still relevant? If not, maybe remove this comment? In any case, it's necessary to check how it works on SLES12 SP5 and contemporary SLES15 releases (checking against SP5 and maybe SP6 should be enough, assuming the latter one is already available to you). -- To view, visit http://gerrit.cloudera.org:8080/21569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I563e188b6692ebfe0e0b3e98577961a8380f1f31 Gerrit-Change-Number: 21569 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 11 Jul 2024 18:47:27 +0000 Gerrit-HasComments: Yes
