Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21572 )
Change subject: [log] fix the Ranger client log count limit not working ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21572/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21572/1//COMMIT_MSG@12 PS1, Line 12: ava subprocess was not : limited What the maximum number of files you have seen? By default, the maximum is set to 10, so the roll-over starts only after 10 files are there. http://gerrit.cloudera.org:8080/#/c/21572/1/src/kudu/subprocess/subprocess_proxy-test.cc File src/kudu/subprocess/subprocess_proxy-test.cc: http://gerrit.cloudera.org:8080/#/c/21572/1/src/kudu/subprocess/subprocess_proxy-test.cc@147 PS1, Line 147: const nit: could be 'constexpr'? http://gerrit.cloudera.org:8080/#/c/21572/1/src/kudu/subprocess/subprocess_proxy-test.cc@151 PS1, Line 151: SleepFor(MonoDelta::FromSeconds(10)); Since this quite long run-time for a test, please add SKIP_IF_SLOW_NOT_ALLOWED() in the very beginning of the test case scope. -- To view, visit http://gerrit.cloudera.org:8080/21572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc528d68947c222fa7be338057ea7af134eb0dd4 Gerrit-Change-Number: 21572 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2024 17:02:11 +0000 Gerrit-HasComments: Yes
