KeDeng has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21572 )

Change subject: [log] fix the Ranger client log count limit not working
......................................................................


Patch Set 2:

(3 comments)

Thanks for your reviews.

http://gerrit.cloudera.org:8080/#/c/21572/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21572/1//COMMIT_MSG@12
PS1, Line 12: ava subprocess was not
            : limited
> What the maximum number of files you have seen?  By default, the maximum is
Approximately between three to four days, 74 files were generated, with a 
maximum of 24 logs produced in a single day so far.


http://gerrit.cloudera.org:8080/#/c/21572/1/src/kudu/subprocess/subprocess_proxy-test.cc
File src/kudu/subprocess/subprocess_proxy-test.cc:

http://gerrit.cloudera.org:8080/#/c/21572/1/src/kudu/subprocess/subprocess_proxy-test.cc@147
PS1, Line 147: SKIP_
> nit: could be 'constexpr'?
Done


http://gerrit.cloudera.org:8080/#/c/21572/1/src/kudu/subprocess/subprocess_proxy-test.cc@151
PS1, Line 151: // Wait for the subprocess to generat
> Since this quite long run-time for a test, please add SKIP_IF_SLOW_NOT_ALLO
Done



--
To view, visit http://gerrit.cloudera.org:8080/21572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc528d68947c222fa7be338057ea7af134eb0dd4
Gerrit-Change-Number: 21572
Gerrit-PatchSet: 2
Gerrit-Owner: KeDeng <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Wed, 17 Jul 2024 08:20:50 +0000
Gerrit-HasComments: Yes

Reply via email to