Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )
Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21604/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21604/3//COMMIT_MSG@10 PS3, Line 10: when FLAGS_block_manager == "logr", : opens a data directory will open a RocksDB instance, it : consumes more time than that if FLAGS_block_manager == "log". Just curious: is factor of 5 is the good estimate in the difference in opening times there? BTW, I also found this: https://github.com/facebook/rocksdb/wiki/Speed-Up-DB-Open Maybe, it makes sense evaluating what options from there needs to be available to tweak in Kudu's logr block manager (that might be a follow-up to https://gerrit.cloudera.org/#/c/21570/). If adding control knobs for some of the options referred, also consider using those recipes to reduce run times of Kudu tests where "logr" block managers is used. Of course, it's all up to you, as usual. http://gerrit.cloudera.org:8080/#/c/21604/3/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/fs_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/21604/3/src/kudu/fs/fs_manager-test.cc@1263 PS3, Line 1263: 1000 : (FLAGS_block_manager == "log" ? 50 : 10); If reducing the number of iterations 5-fold when KUDU_ALLOW_SLOW_TESTS is not set, maybe it makes sense to do the same when KUDU_ALLOW_SLOW_TESTS is set, reducing the number of iterations from 1000 to 200? -- To view, visit http://gerrit.cloudera.org:8080/21604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8 Gerrit-Change-Number: 21604 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 22 Jul 2024 19:23:48 +0000 Gerrit-HasComments: Yes
