Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 )
Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21604/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21604/3//COMMIT_MSG@10 PS3, Line 10: when FLAGS_block_manager == "logr", : opens a data directory will open a RocksDB instance, it : consumes more time than that if FLAGS_block_manager == "log". > Just curious: is factor of 5 is the good estimate in the difference in open It depends on the machine where the test running on, 5 is a good factor on the current Jenkins machines. Thanks for the information! Yes, the mentioned factors "manifest size" can be controlled by the patch https://gerrit.cloudera.org/c/21570/3/src/kudu/fs/dir_manager.cc#352. The second point "WAL replaying" is meaningless on our use case, because we only use a single column family currently. The third point "sst file handlers" has a few meaning, but the metadata part of Kudu fs is not supposed to be very large. Maybe I'll add it in another patch. http://gerrit.cloudera.org:8080/#/c/21604/3/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/fs_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/21604/3/src/kudu/fs/fs_manager-test.cc@1263 PS3, Line 1263: 1000 : (FLAGS_block_manager == "log" ? 50 : 10); > If reducing the number of iterations 5-fold when KUDU_ALLOW_SLOW_TESTS is n The ASAN, TSAN is added (and the value is lowered) when logr initially introduced https://gerrit.cloudera.org/c/18569/, so I decided to remove the confused and complex judgement in PS1. It would be more readable. It's a "fuzz" test, the loop times doesn't take effect on the correctness. The loop times can be controlled by a flag if some day any body want to control it conveniently. -- To view, visit http://gerrit.cloudera.org:8080/21604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56a03d64c8ababd63fe31fa1e7fce1efac3875e8 Gerrit-Change-Number: 21604 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sun, 28 Jul 2024 16:28:36 +0000 Gerrit-HasComments: Yes
