Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20868 )
Change subject: KUDU-3543 Fix Content-Type headers ...................................................................... Patch Set 6: (12 comments) http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/master/master-test.cc@3818 PS5, Line 3818: > nit: this could be just a const ref since create_table_resp is kept around, Done http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/master/master-test.cc@3828 PS5, Line 3828: const auto addr = Substitute("http://$0";, mini_master_->bound_http_addr().ToString()); > nit: ditto -- consider adding 'const', and maybe also switch to 'auto' inst Done http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/master/master-test.cc@3834 PS5, Line 3834: > nit: could get rid of extra variable and inline the call to Substitute righ Done http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/tserver/tablet_server-test.cc@623 PS5, Line 623: TEST_F(TabletServerTest, TestTabletServerContentTypeHeaders) { > nit: same as for master-test.cc Done http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/util/test_util.h File src/kudu/util/test_util.h: http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/util/test_util.h@205 PS5, Line 205: // Contains the endpoints which are to be found on Master and TServer as well. > Please document each of the newly added functions. Essentially, the name i Done http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/util/test_util.cc@659 PS5, Line 659: > nit: consider instantiating static instance of a map and returning const re Done http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/util/test_util.cc@688 PS5, Line 688: {"tracing/json/end_recording", kContentTypeTextPlain}, > What if this list starts diverging from the actual list of the endpoints se This is a valid concern. Looked around a bit and did not find any easy way to do so. However this would be definitely something to address in the future. For that I created a ticket to track this improvement: KUDU-3602. http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/util/test_util.cc@692 PS5, Line 692: } > nit here and elsewhere: add corresponding 'using' directive and remove 'std Done http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/util/test_util.cc@692 PS5, Line 692: > nit: remove the 'std' prefix since there is corresponding 'using' directive Done http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/util/test_util.cc@694 PS5, Line 694: // Add necessary query params to get 200 response in tests. > nit: ditto for changing the signature of this function Done http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/util/test_util.cc@696 PS5, Line 696: nst unord > nit for here and below: remove the 'strings::' prefix since there is corres Done http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/util/test_util.cc@708 PS5, Line 708: > nit: ditto for changing the signature of this function Done -- To view, visit http://gerrit.cloudera.org:8080/20868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I746dcfbaadb2fb95292c2d4047cb7adb9971b42f Gerrit-Change-Number: 20868 Gerrit-PatchSet: 6 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2024 09:52:18 +0000 Gerrit-HasComments: Yes
