Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20868 )
Change subject: KUDU-3543 Fix Content-Type headers ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/20868/5/src/kudu/util/test_util.cc@688 PS5, Line 688: {"tracing/json/end_recording", kContentTypeTextPlain}, > This is a valid concern. Looked around a bit and did not find any easy way Yep, addressing that in a separate changelist should be a good option. Thank you! http://gerrit.cloudera.org:8080/#/c/20868/6/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: http://gerrit.cloudera.org:8080/#/c/20868/6/src/kudu/util/test_util.cc@660 PS6, Line 660: const unordered_map<string, string> nit: is it possible avoid copying by returning a const reference? const unordered_map<string, string>& GetCommonWebserverEndpoints() { ... } http://gerrit.cloudera.org:8080/#/c/20868/6/src/kudu/util/test_util.cc@695 PS6, Line 695: const unordered_map<string, string> GetTServerWebserverEndpoints(const string& tablet_id) { ditto http://gerrit.cloudera.org:8080/#/c/20868/6/src/kudu/util/test_util.cc@710 PS6, Line 710: const unordered_map<string, string> GetMasterWebserverEndpoints(const string& table_id) { ditto -- To view, visit http://gerrit.cloudera.org:8080/20868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I746dcfbaadb2fb95292c2d4047cb7adb9971b42f Gerrit-Change-Number: 20868 Gerrit-PatchSet: 6 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2024 21:33:17 +0000 Gerrit-HasComments: Yes
