Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21601 )
Change subject: KUDU-613: SLRU Cache Benchmark ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21601/4/src/kudu/util/cache-bench.cc File src/kudu/util/cache-bench.cc: http://gerrit.cloudera.org:8080/#/c/21601/4/src/kudu/util/cache-bench.cc@194 PS4, Line 194: frequent = i % 2 == 0; : threads[i] = thread([&]() { I guess 'frequent' is still passed by reference here. You could explicitly specify in the lambda's capture passing 'frequent' by value instead. -- To view, visit http://gerrit.cloudera.org:8080/21601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c128a9f047497373ce3e740056eaa89a352261b Gerrit-Change-Number: 21601 Gerrit-PatchSet: 4 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 14 Aug 2024 00:45:52 +0000 Gerrit-HasComments: Yes
