Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21601 )
Change subject: KUDU-613: SLRU Cache Benchmark ...................................................................... Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21601/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21601/5//COMMIT_MSG@28 PS5, Line 28: UNIFORM ratio=1.00x | SLRU | 7.58M | 99.7% Compared with the results posted with PS3, this stands out -- it was 50%, now it's 99.7%. Did you try verifying this by running the benchmark a few times? Also, could you please post an update for the numbers with the benchmark bits built from PS5? The way how the 'frequent' was used in the lambda's capture in pre-PS5 could introduce extra volatility and non-determinism, so I'd really like to have the numbers that correspond to the code in PS5. Thank you! -- To view, visit http://gerrit.cloudera.org:8080/21601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c128a9f047497373ce3e740056eaa89a352261b Gerrit-Change-Number: 21601 Gerrit-PatchSet: 5 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 14 Aug 2024 19:04:39 +0000 Gerrit-HasComments: Yes
