KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21672 )
Change subject: [tool] sandardize the output of rebalance report tool ...................................................................... Patch Set 2: (1 comment) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/21672/1/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/21672/1/src/kudu/tools/ksck.cc@646 PS1, Line 646: return Status::NotAuthorized("re-run ksck with administrator privileges"); > It's duplicate with line 634. Thank you for your reminder. I have already replaced the duplicate parts of the code. Ksck::Run() will return an authentication error, but in the use of the rebalance tool, to avoid the impact of temporary cluster health issues, the return result of this function is ignored, as implemented in line 262 of tool_action_cluster.cc. This can cause the authentication error to be overlooked, resulting in unexpected output. -- To view, visit http://gerrit.cloudera.org:8080/21672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If844be1f7ccd156582f1ffa7137c8a711c49178d Gerrit-Change-Number: 21672 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 15 Aug 2024 02:44:30 +0000 Gerrit-HasComments: Yes
