Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21672 )
Change subject: [tool] sandardize the output of rebalance report tool ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21672/2/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: http://gerrit.cloudera.org:8080/#/c/21672/2/src/kudu/tools/tool_action_cluster.cc@262 PS2, Line 262: ignore_result What about just judge if the returned Status is NotAuthorized, and RETURN_NOT_OK if it is. Then it's not needed to add a new function CheckAuthorizedResults. -- To view, visit http://gerrit.cloudera.org:8080/21672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If844be1f7ccd156582f1ffa7137c8a711c49178d Gerrit-Change-Number: 21672 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 15 Aug 2024 09:58:40 +0000 Gerrit-HasComments: Yes
