KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21672 )
Change subject: [tool] standardize the output of rebalance report tool ...................................................................... Patch Set 4: (3 comments) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/21672/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21672/3//COMMIT_MSG@7 PS3, Line 7: standardiz > nit: standardize Done http://gerrit.cloudera.org:8080/#/c/21672/3//COMMIT_MSG@15 PS3, Line 15: . > nit: add space after period. Done http://gerrit.cloudera.org:8080/#/c/21672/3/src/kudu/tools/tool_action_cluster.cc File src/kudu/tools/tool_action_cluster.cc: http://gerrit.cloudera.org:8080/#/c/21672/3/src/kudu/tools/tool_action_cluster.cc@264 PS3, Line 264: } > nit: use RETURN_NOT_OK_PREPEND will be better to keep the message returned Done -- To view, visit http://gerrit.cloudera.org:8080/21672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If844be1f7ccd156582f1ffa7137c8a711c49178d Gerrit-Change-Number: 21672 Gerrit-PatchSet: 4 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 16 Aug 2024 02:27:55 +0000 Gerrit-HasComments: Yes
