Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21695 )
Change subject: [tools] Copy table with non-continuous column ids ...................................................................... Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/21695/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21695/2//COMMIT_MSG@11 PS2, Line 11: existed distination nit: existing destination http://gerrit.cloudera.org:8080/#/c/21695/2//COMMIT_MSG@19 PS2, Line 19: check : the consistent of shcemas. nit: checking if the schemas match. http://gerrit.cloudera.org:8080/#/c/21695/2/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/21695/2/src/kudu/tools/table_scanner.cc@147 PS2, Line 147: compare nit: comparing http://gerrit.cloudera.org:8080/#/c/21695/2/src/kudu/tools/table_scanner.cc@147 PS2, Line 147: It's allowed the destination " : "table to nit: The destination table can http://gerrit.cloudera.org:8080/#/c/21695/2/src/kudu/tools/table_scanner.cc@421 PS2, Line 421: CheckSchemaMatched nit: rename to 'SchemasMatch'? http://gerrit.cloudera.org:8080/#/c/21695/2/src/kudu/tools/table_scanner.cc@428 PS2, Line 428: using nit: uses http://gerrit.cloudera.org:8080/#/c/21695/2/src/kudu/tools/table_scanner.cc@463 PS2, Line 463: Destination nit: destination http://gerrit.cloudera.org:8080/#/c/21695/2/src/kudu/tools/table_scanner.cc@631 PS2, Line 631: the schemas are matched. nit: that the schemas match. -- To view, visit http://gerrit.cloudera.org:8080/21695 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77af7b92b45f3866cc8b699e61b9e71b73ed6c4b Gerrit-Change-Number: 21695 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 20 Aug 2024 20:41:36 +0000 Gerrit-HasComments: Yes
