Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21695 )
Change subject: [tools] Copy table with non-continuous column ids ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/21695/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21695/3//COMMIT_MSG@12 PS3, Line 12: it : will report an error saying that they have different : schemas, but the difference is not shown. > Before this patch we compared schemas of tables when doing table copy, seem Yes, you're right, there is no problem now. In fact, this is a part of work of KUDU-3606, it requires the source and destination tables' column ids are one-to-one corresponding. We can merge this patch after the main work of KUDU-3606 has been merged. http://gerrit.cloudera.org:8080/#/c/21695/3//COMMIT_MSG@22 PS3, Line 22: A new flag --show_column_id is also added to : indicate whether to show column ids when using : 'kudu table describe'. > nit: This part of change should be put in another patch, because it is for Done http://gerrit.cloudera.org:8080/#/c/21695/3/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/21695/3/src/kudu/tools/table_scanner.cc@446 PS3, Line 446: auto > nit: Is this change necessary? Not necessary, but my IDE prompt it. It's a modernize change. -- To view, visit http://gerrit.cloudera.org:8080/21695 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77af7b92b45f3866cc8b699e61b9e71b73ed6c4b Gerrit-Change-Number: 21695 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 23 Aug 2024 07:23:22 +0000 Gerrit-HasComments: Yes
