KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21673 )
Change subject: [ranger] enhance the robustness of key retrieval ...................................................................... Patch Set 5: (7 comments) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/21673/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21673/5//COMMIT_MSG@9 PS5, Line 9: In scenarios where encryption keys are generated using Ranger > Do you mean existing Kudu test scenarios or that was something else? Our use case involves integrating Ranger's key request, meaning that once the user selects the machine configuration for installing the authentication Kudu program, the subsequent operations are automated. During this process, we discovered that there is approximately a 50% chance of failure in the authentication scenario, which is the error described below. We did not encounter this issue in unit testing. http://gerrit.cloudera.org:8080/#/c/21673/5//COMMIT_MSG@15 PS5, Line 15: the new user > nit: a new user Done http://gerrit.cloudera.org:8080/#/c/21673/5//COMMIT_MSG@21 PS5, Line 21: there are no logical changes > Well, there is a change, actually -- now there is a retry :) Done http://gerrit.cloudera.org:8080/#/c/21673/5/src/kudu/ranger-kms/ranger_kms_client.cc File src/kudu/ranger-kms/ranger_kms_client.cc: http://gerrit.cloudera.org:8080/#/c/21673/5/src/kudu/ranger-kms/ranger_kms_client.cc@37 PS5, Line 37: key generate > the key generation Done http://gerrit.cloudera.org:8080/#/c/21673/5/src/kudu/ranger-kms/ranger_kms_client.cc@114 PS5, Line 114: MonoTime now; > As of PS5, this variable doesn't seem to be used anymore, just assigned at Done http://gerrit.cloudera.org:8080/#/c/21673/5/src/kudu/ranger-kms/ranger_kms_client.cc@139 PS5, Line 139: Failed to generate server key > nit: consider defining this constant at the upper level and using it in the Done http://gerrit.cloudera.org:8080/#/c/21673/5/src/kudu/ranger-kms/ranger_kms_client.cc@139 PS5, Line 139: constexpr const char* > nit: constexpr const char* const ? Done -- To view, visit http://gerrit.cloudera.org:8080/21673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fd3263ad6ba6d8e444036bb7d2158986098cb4b Gerrit-Change-Number: 21673 Gerrit-PatchSet: 5 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 26 Aug 2024 03:08:44 +0000 Gerrit-HasComments: Yes
