KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/21673 )
Change subject: [ranger] enhance the robustness of key retrieval ...................................................................... Patch Set 8: (2 comments) Thanks for your reviews. http://gerrit.cloudera.org:8080/#/c/21673/7/src/kudu/ranger-kms/ranger_kms_client.cc File src/kudu/ranger-kms/ranger_kms_client.cc: http://gerrit.cloudera.org:8080/#/c/21673/7/src/kudu/ranger-kms/ranger_kms_client.cc@115 PS7, Line 115: > nit: rename to 'error_msg'? Because it may be other errors rather than time Done http://gerrit.cloudera.org:8080/#/c/21673/7/src/kudu/ranger-kms/ranger_kms_client.cc@137 PS7, Line 137: > How about using LOG_AND_RETURN to simplify the code? Done -- To view, visit http://gerrit.cloudera.org:8080/21673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fd3263ad6ba6d8e444036bb7d2158986098cb4b Gerrit-Change-Number: 21673 Gerrit-PatchSet: 8 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 23 Sep 2024 06:25:02 +0000 Gerrit-HasComments: Yes
