Hello Mahesh Reddy, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/21789
to review the following change.
Change subject: [gutil] fix compilation with clang 15
......................................................................
[gutil] fix compilation with clang 15
std::{binary,unary}_function have been deprecated since C++11 and
removed in C++17 [1], and it seems that CLANG 15 which comes with
Xcode 15.3 on macOS enforces this particular part of the C++17 standard.
In this instance, it's easy to address the issue because nothing
essential was used from std::unary_function and std::binary_function
but just typedefs which are no longer needed by the new standard library
anyway. Since Kudu switched to C++17 a long time ago [2], the solution
is to stop inheriting from the deprecated classes.
[1] https://en.cppreference.com/w/cpp/utility/functional/unary_function
[2]
https://github.com/apache/kudu/commit/e432e637e282ba87d41c02088a801f0838571edc
Change-Id: I3329427c3babd57418c83ab2401b7c4d29e14020
Reviewed-on: http://gerrit.cloudera.org:8080/21206
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Mahesh Reddy <[email protected]>
Reviewed-by: Abhishek Chennaka <[email protected]>
(cherry picked from commit 4dc4100fe5cf994cccb5d87cc398e79dde038686)
---
M src/kudu/gutil/stl_util.h
M src/kudu/gutil/strings/human_readable.h
M src/kudu/gutil/strings/numbers.h
M src/kudu/gutil/strings/util.h
4 files changed, 13 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/21789/1
--
To view, visit http://gerrit.cloudera.org:8080/21789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3329427c3babd57418c83ab2401b7c4d29e14020
Gerrit-Change-Number: 21789
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
