Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21731 )
Change subject: [java][build] KUDU-3610: kudu-client.jar dependencies ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/21731/6//COMMIT_MSG Commit Message: PS6: > The dependencies themselves are correct, I updated the commit message with Thank you for adding the clarification note: it's useful. http://gerrit.cloudera.org:8080/#/c/21731/6/java/kudu-client/build.gradle File java/kudu-client/build.gradle: http://gerrit.cloudera.org:8080/#/c/21731/6/java/kudu-client/build.gradle@27 PS6, Line 27: api libs.protobufJava > it leads to a compilation error if you remove it Ah, I see. It was enough to have a transitive dependency via kudu-proto earlier, but it seems something has changed. http://gerrit.cloudera.org:8080/#/c/21731/11/java/kudu-client/build.gradle File java/kudu-client/build.gradle: http://gerrit.cloudera.org:8080/#/c/21731/11/java/kudu-client/build.gradle@26 PS11, Line 26: api Do we really expose anything from kudu-proto in the API of the kudu-client JAR? Probably, I'm missing something, but I'd expect this to be just 'implementation', not 'api' type of dependency. The same for the rest of 'implementation' --> 'api' dependency type updates in this file. This looks a bit off, so I wanted to double-check to clarify on this. I found this article that looks like a good read on the related items: https://tomgregory.com/gradle/how-to-use-gradle-api-vs-implementation-dependencies-with-the-java-library-plugin/ http://gerrit.cloudera.org:8080/#/c/21731/11/java/kudu-client/build.gradle@27 PS11, Line 27: api Is this only because of the trustedCertificates() method that uses com.google.protobuf.ByteString? Do we have anything else in the API of kudu-client that requires us to use 'api' here for protobuf instead of 'implemenation'? -- To view, visit http://gerrit.cloudera.org:8080/21731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I607d7c62c585b2aa1bee4ebf7907309e130092da Gerrit-Change-Number: 21731 Gerrit-PatchSet: 11 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 14 Oct 2024 17:30:17 +0000 Gerrit-HasComments: Yes
